issue_139: check invalid url

catalyst · May 28, 2020 · ea1cc68 · ea1cc68
1 parent 55fa243
commit ea1cc68
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/classes/robot/crawler.php b/classes/robot/crawler.php
@@ -285,6 +285,11 @@ public function mark_for_crawl($baseurl, $url, $courseid = null, $priority = TOO
         global $DB, $CFG;
 
         $url = $this->absolute_url($baseurl, $url);
+        $url = clean_param($url, PARAM_URL);
+
+        if (empty($url)) {
+            return false;
+        }
 
         // Strip priority from indirect child nodes. Only parent and direct children
         // of parent nodes have priority applied to avoid recursively applying priority

diff --git a/tests/phpunit/robot_crawler_test.php b/tests/phpunit/robot_crawler_test.php
@@ -228,6 +228,16 @@ public function test_uri_escaping() {
         self::assertRegExp($expectedpattern, $page);
     }
 
+    /**
+     * Test for checking invalid url
+     */
+    public function test_invalid_url() {
+        $baseurl = 'http://';
+        $relativeurl = '<invalidurl>';
+        $result = $this->robot->mark_for_crawl($baseurl, $relativeurl);
+        self::assertEquals(false, $result);
+    }
+
     /**
      * Regression test for an issue similar to Issue #48: redirection URI must be escaped when it is output to an HTML document.
      */