Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loghandlers now optional and saving an existing flow should work #830

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: loghandlers now optional and saving an existing flow should work #830

merged 1 commit into from
Aug 24, 2023

Conversation

keevan
Copy link
Contributor

@keevan keevan commented Aug 24, 2023 •
edited
Loading

Resolves #829

Before:

image

After:

image

Peterburnett
Peterburnett approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@Peterburnett Peterburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just updating the persistent def to match the schema. LGTM

@Peterburnett Peterburnett merged commit 150b682 into MOODLE_35_STABLE Aug 24, 2023
25 checks passed
@Peterburnett Peterburnett deleted the 829-fix-loghandler-persistent-errors branch August 24, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peterburnett Peterburnett Peterburnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persistent errors when saving an existing or importing a dataflow without log handlers
2 participants
@keevan @Peterburnett