This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add HTTP/W3C text format serializer to Tag propagation component #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 95% 95.02% +0.02%
==========================================
Files 147 149 +2
Lines 9566 9655 +89
Branches 680 683 +3
==========================================
+ Hits 9088 9175 +87
- Misses 478 480 +2
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Mar 25, 2019
| * | ||
| * OpenCensus uses W3C Correlation Context as the HTTP text format. | ||
| * https://github.com/w3c/correlation-context/blob/master/correlation_context/ | ||
| * HTTP_HEADER_FORMAT.md |
There was a problem hiding this comment.
Nit: could you move the HTTP_HEADER_FORMAT.md to the line above so the link is not broken across lines? I think links are a good exception to the 80 char line limit
songy23
approved these changes
Mar 26, 2019
Yes, the actual use of the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #297 This is the HTTP version of of #431.
Based on W3C correlation context format: https://github.com/w3c/correlation-context/blob/master/correlation_context/HTTP_HEADER_FORMAT.md
There will be another PR to use these serializer functions in the HTTP plugin to propagate tags on wire.