Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Fix stats example #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

directionless
Copy link

@directionless directionless commented Apr 5, 2019

This fixes the stats example.

Exporters don’t work.

But I’m sure my comments are wrong. But it’s a start

This fixes the stats example.

Exporters don’t work. And I’m sure my comments are wrong. But it’s a start
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@directionless
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@directionless directionless changed the title Fix stats example (draft) Fix stats example Apr 12, 2019
@dazuma
Copy link
Member

dazuma commented Apr 21, 2019

@jiren Can you review this and verify it's in line with the current stats code?

@jiren
Copy link
Contributor

jiren commented Apr 21, 2019

@jiren Can you review this and verify it's in line with the current stats code?

Yes, look good as per current stats code.

Just for information, this example needs to be updated once the Tag metadata code is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants