Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibm-ceph: include swidtag file #2159

Merged
merged 2 commits into from
Oct 2, 2023
Merged

ibm-ceph: include swidtag file #2159

merged 2 commits into from
Oct 2, 2023

Conversation

guits
Copy link
Collaborator

@guits guits commented Sep 27, 2023

This change includes the swidtag for IBM Ceph 6.1.2

Signed-off-by: Guillaume Abrioux [email protected]

@guits
ibm-ceph: ceph-mgr-callhome integration
0eabc91 
This adds the required changes to include ceph-mgr-callhome in the
IBM Ceph container image.

Fixes: #2147

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits
ibm-ceph: include swidtag file
d4fa189 
This change includes the swidtag for IBM Ceph 6.1.2

Signed-off-by: Guillaume Abrioux <[email protected]>
andrewschoen
andrewschoen approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@andrewschoen andrewschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I guess then we'd just store the ibm.com_IBM_Storage_Ceph-6.1.2.swidtag file in dist-git where this is built downstream, is that right?

@guits
Copy link
Collaborator Author

guits commented Sep 28, 2023

This looks good to me. I guess then we'd just store the ibm.com_IBM_Storage_Ceph-6.1.2.swidtag file in dist-git where this is built downstream, is that right?

that is correct, yes

@andrewschoen
Copy link
Contributor

This looks good to me. I guess then we'd just store the ibm.com_IBM_Storage_Ceph-6.1.2.swidtag file in dist-git where this is built downstream, is that right?

that is correct, yes

Great, that sounds good to me.

@guits guits merged commit 7d3735a into main Oct 2, 2023
8 checks passed
@guits guits deleted the swidtag branch October 2, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewschoen andrewschoen andrewschoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guits @andrewschoen