tweaks: use full-line commands to sed #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures seem to be related to being unable to get hold of the repo at all, rather than objecting to the contents of the change. |
|
|
jenkins retest this please |
|
@mcv21 hi Mathew, i retriggered the jenkins jobs previously failed due to infra issues. but the github "container" workflows are failing. |
|
[I'm at the point where AFAICT the previous sed runes shouldn't have worked, given |
A safety tweak to make sure we only edit whole lines that match. Also handle the lines we're edited being commented out; add a couple of echos to add any future debugging (which, given the amount of output from a successful build seems like a low-cost move). Signed-off-by: Matthew Vernon <[email protected]>
|
OK, that's more robustly working now, and I've tidied up the branch history too, so I think this is ready for review now. |
|
@guits bonjour Guillaume, could you help review this change? |
guits
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A safety tweak to make sure we only edit whole lines that match; also handle commented-out lines.
Checklist:
(neither of those things necessary here, I think)