Add the COPR for grpc for centos 8 daemon-base #2198
Conversation
Because of a new dependency in spdk, grpc and protobuf tools are now required for the build, but not all the pieces exist in epel8. ktdreyer constructed a copr to hold the packages. Dependencies (namely libprotobuf.so) are present in epel8. Signed-off-by: Dan Mick <[email protected]>
|
I tested this locally with an x86_64 build; I tried also to test with arm64, but the build process couldn't find a ceph-release package. I assume that's because the arm64 crimson ceph base build hasn't been succeeding, but I'm going ahead with this PR anyway until we can sort arm64 separately |
| @@ -112,5 +112,8 @@ bash -c ' \ | |||
| yum install -y dnf-plugins-core ; \ | |||
| yum copr enable -y tchaikov/python-scikit-learn ; \ | |||
| yum copr enable -y tchaikov/python3-asyncssh ; \ | |||
| if [[ "${OSD_FLAVOR}" == "crimson" ]] ; then \ | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
The point was that crimson needed grpc/protobuf because of new code in spdk, and we know it wasn't upstream for 8stream, which is why Ken made the copr. I don't understand what you're saying.
There was a problem hiding this comment.
@nizamial09 explained the saga to me. We have three separate consumers of grpc, apparently: dashboard, nvmeof, and crimson (at least the latter because of a new version of spdk).
There was a problem hiding this comment.
Thanks for clarifying that in this comment Dan. I could not even remember all three of those.
Because of a new dependency in spdk, grpc and protobuf tools are now required for the build, but not all the pieces exist in epel8. ktdreyer constructed a copr to hold the packages. Dependencies (namely libprotobuf.so) are present in epel8.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist: