Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify differences between example configs for CA issuer and cluster CA issuer #1516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify differences between example configs for CA issuer and cluster CA issuer #1516

wants to merge 1 commit into from

Conversation

apiwat-chantawibul
Copy link

@apiwat-chantawibul apiwat-chantawibul commented Jul 16, 2024 •
edited
Loading

  • Especially around the issue that CA root secret has to be in cert-manager namespace.
  • Previous version starts off by suggesting the differences is only in "the last step" when in fact CA root secret has also moved to another namespace.

Might need further correction

  • Is the namespace for CA root secret always assumed to be cert-manager when creating cluster CA issuer?
    • What happens if cert-manger is not installed in cert-manager namespace?
    • I don't know these so I didn't write more specifically in the edit.

@apiwat-chantawibul
Clarify differences in examples
df93cfa 
between the config for CA issuer and cluster CA issuer.
Especially around the issue that CA root secret has to be in `cert-manager` namespace.

Signed-off-by: apiwat-chantawibul <[email protected]>
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 16, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 16, 2024
@apiwat-chantawibul apiwat-chantawibul changed the title Clarify differences in between examples config for CA issuer and cluster CA issuer Clarify differences between example configs for CA issuer and cluster CA issuer Jul 16, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df93cfa
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/6695ef972d2f090008bb89f5
😎 Deploy Preview https://deploy-preview-1516--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apiwat-chantawibul