Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the meetings and slack information to a separate page #859

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+29 −23
Open

Move the meetings and slack information to a separate page #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c11fc2a
Move the meetings and slack information to a separate page
wallrj Mar 10, 2022
b20e31f
Update some links
wallrj Mar 10, 2022
84f4358
Fix the menu item and rename the new page
wallrj Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions content/en/docs/contributing/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,24 +27,6 @@ external cert-manager components:

Hello new or existing contributor!
Welcome to our contributors documentation, this is the place where we document all our processes
as well as how to compile, run and test cert-manager and all it's components.
as well as how to compile, run and test cert-manager and all its components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Can't believe I didn't see this before! 👀 Good spot!

This document sometimes can get out of date due to changes in the code and/or tooling. PRs to this part are
also very welcome if you happen to find an out of date part.

## Meetings

All cert-manager meetings are open for everyone to join.

To get invites you can subscribe to [our mailing list](https://groups.google.com/forum/#!forum/cert-manager-dev).

We have 2 regular repeating meetings:

* daily stand-up meetings [on Google Meet](https://meet.google.com/eum-fyvt-xpa) at [10:30 London time](http://www.thetimezoneconverter.com/?t=10:30&tz=Europe/London) every weekday
* bi-weekly developer meetings [on Google Meet](https://meet.google.com/abp-bwhk-wxc) at [17:00 London time](http://www.thetimezoneconverter.com/?t=17:00&tz=Europe/London) (for dates, check calendar invites or [meeting notes](https://docs.google.com/document/d/1Tc5t6ylY9dhXAan1OjOoldeaoys1Yh4Ir710ATfBa5U))

## Slack

We have two cert-manager channels on [the Kubernetes Slack](https://slack.k8s.io) which we use to communicate:

* `cert-manager`: a general channel for all users of cert-manager; use this one for any usage related questions.
* `cert-manager-dev`: a channel for collaboration between cert-manager contributors and maintainers; please only use this for code related questions
Comment on lines -34 to -50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: (just seen this PR by chance) I feel like we have a lot of places where we directly link to these links:

https://cert-manager.io/docs/contributing/#meetings
https://cert-manager.io/docs/contributing/#slack

E.g. we used them in the slides for our recent TAG Security presentation, and I've used them in slack a lot before.

I think we'd massively benefit from adding redirects from those links to the new page, so that users with the old links end up in the right place. Is that possible?

24 changes: 24 additions & 0 deletions content/en/docs/contributing/contact-the-maintainers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
title: "Contact the maintainers"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: I find that this title does not really reflect the content well, from the name I would expect this to contain our email address, these communication channels are imo for different type of involvement, i.e asking a question that could be answered by other community members on cert-manager Slack. I also cannot think of a perfect name, but would suggest 'Community'

linkTitle: "Contact the maintainers"
weight: 70
type: "docs"
---

## Meetings

All cert-manager meetings are open for everyone to join.

To get invites you can subscribe to [our mailing list](https://groups.google.com/forum/#!forum/cert-manager-dev).

We have 2 regular repeating meetings:

* daily stand-up meetings [on Google Meet](https://meet.google.com/eum-fyvt-xpa) at [10:30 London time](http://www.thetimezoneconverter.com/?t=10:30&tz=Europe/London) every weekday
* bi-weekly developer meetings [on Google Meet](https://meet.google.com/abp-bwhk-wxc) at [17:00 London time](http://www.thetimezoneconverter.com/?t=17:00&tz=Europe/London) (for dates, check calendar invites or [meeting notes](https://docs.google.com/document/d/1Tc5t6ylY9dhXAan1OjOoldeaoys1Yh4Ir710ATfBa5U))

## Slack

We have two cert-manager channels on [the Kubernetes Slack](https://slack.k8s.io) which we use to communicate:

* `cert-manager`: a general channel for all users of cert-manager; use this one for any usage related questions.
* `cert-manager-dev`: a channel for collaboration between cert-manager contributors and maintainers; please only use this for code related questions
6 changes: 3 additions & 3 deletions content/en/docs/contributing/importing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ You might need to import cert-manager if you're writing Go code which:
- implements an external DNS solver webhook, as in the [webhook-example](https://github.com/cert-manager/webhook-example)
- implements an external issuer, as in the [sample-external-issuer](https://github.com/cert-manager/sample-external-issuer)

If you think you really need to import other parts of the code, please do reach out and [talk to us](../#slack) so we're
If you think you really need to import other parts of the code, please do reach out and [talk to us](../contact-the-maintainers/#slack) so we're
aware of this need! We'll always try to avoid breakage where we can.

## Module Import Paths
Expand All @@ -37,9 +37,9 @@ migrated to `https://github.com/cert-manager/cert-manager`.

This means the Go module import path you need depends on the version of cert-manager you're trying to use.

For cert-manager 1.8 and later, use the new path:
For cert-manager 1.8 and later, use the new path:
`github.com/cert-manager/cert-manager`


For cert-manager 1.7 and earlier, including all point releases, use the old path:
For cert-manager 1.7 and earlier, including all point releases, use the old path:
`github.com/jetstack/cert-manager`
2 changes: 1 addition & 1 deletion content/en/docs/release-notes/release-notes-1.7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ Thanks again to all open-source contributors with commits in this release, inclu
And thanks as usual to [coderanger](https://github.com/coderanger) for helping people
out on the [`#cert-manager` Slack channel]; it's a huge help and much appreciated.

[`#cert-manager` Slack channel]: ../../contributing/#slack
[`#cert-manager` Slack channel]: ../../contributing/contact-the-maintainers/#slack

### Changelog since v1.6.0

Expand Down