-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to configure cert-manager via OLM #983
Conversation
Signed-off-by: Richard Wall <[email protected]>
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
…urce Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
/lgtm
> 🔰 Refer to the [Subscription API documentation](https://pkg.go.dev/github.com/operator-framework/[email protected]/pkg/operators/v1alpha1#Subscription). | ||
|
||
Here are some examples of configuration that can be achieved by modifying the Subscription resource. | ||
In each case we assume that you are starting with the following [default Subscription from OperatorHub.io]((https://operatorhub.io/install/cert-manager.yaml)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In each case we assume that you are starting with the following [default Subscription from OperatorHub.io]((https://operatorhub.io/install/cert-manager.yaml)): | |
In each case we assume that you are starting with the following [default Subscription from OperatorHub.io](https://operatorhub.io/install/cert-manager.yaml): |
@@ -91,9 +91,146 @@ in accordance with [OLM's Recommended Channel Naming][]. | |||
If you have any issues with your installation, please refer to the | |||
[FAQ](../faq/README.md). | |||
|
|||
## Configuration | |||
|
|||
The configuration options are quite limited when you install cert-manager using OLM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity: are the options limited because of limitations with OLM or is it limitation we have imposed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current version of OLM has limited support for modifying the deployment, as documented in this PR.
For example, it does not provide an easy way for the OLM package author to allow the container command line flags to be overridden.
But on the other hand, if all the cert-manager components could be configured using a config file in a configmap and if all the existing command line options could also be declared inthose config files, that particular problem would be solved.
There are some other limitations such as not being able to customize the resource requests of individual Deployments in the OLM package:
The current API seems to be designed around there only being a single Deployment in each package, but cert-manager has three.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jahrlin, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've tried to document the OLM configuration options that are available today and mention some of the limitations.
Part of: