Skip to content

Commit

Permalink
fix: add superagent types as prod dependency (#347)
Browse files Browse the repository at this point in the history
We expose superagent's types in our own types, so this should be a
production dependency. Otherwise, we will cause errors in the typescript
builds of consumers (unless they skip lib check).

It does mean we add an unnecessary dependency for non-ts people, but
there's not any simple way around that.
  • Loading branch information
43081j authored Nov 19, 2024
1 parent 08daa24 commit 28f4426
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
13 changes: 4 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@
"is-ip": "^5.0.1",
"methods": "^1.1.2",
"qs": "^6.12.1",
"@types/superagent": "^8.1.7",
"superagent": "^9"
},
"devDependencies": {
"@eslint/js": "^9.3.0",
"@types/chai": "^4.3.16",
"@types/superagent": "^8.1.7",
"chai": "^5.1.0",
"coveralls": "^3.1.1",
"eslint": "^9.3.0",
Expand Down

0 comments on commit 28f4426

Please sign in to comment.