Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch fake collections throwing #100

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix: catch fake collections throwing #100

merged 1 commit into from
Jun 3, 2024

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented May 31, 2024

Fixes #99

@ljharb ljharb mentioned this pull request May 31, 2024
Closed
keithamus
keithamus approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keithamus keithamus merged commit 8c14040 into chaijs:main Jun 3, 2024
1 check passed
@ljharb ljharb deleted the slots branch June 3, 2024 14:52
ljharb added a commit to ljharb/deep-eql that referenced this pull request Jun 4, 2024
@ljharb
fix: catch fake collections throwing (chaijs#100)
bf2bb4d 
Fixes chaijs#99
keithamus pushed a commit that referenced this pull request Jun 5, 2024
@ljharb
fix: catch fake collections throwing (#100) (#101)
377458d 
Fixes #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

comparing a fake Map, Set, etc throws
2 participants
@ljharb @keithamus