fix: emit declarations and lib via tsc #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes from using esbuild to emit library code, and instead uses typescript itself. We don't currently ship type declarations since esbuild will not output them.
|
Seems good to me. Not sure why we wouldn't just use the TypeScript compiler. Is there any significant difference between the generated outputs? |
seems to be near enough the same, if not better i noticed esbuild produces think we should be ok to merge this |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes from using esbuild to emit library code, and instead uses typescript itself.
We don't currently ship type declarations since esbuild will not output them.
@keithamus @koddsson can we do this? i feel like we must've had a reason in the past to use esbuild, would be good to know what that was
right now we don't produce (or ship) declarations, which is what this will fix