Remove unnecessary joins in getUserByFirebaseId method #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dockerfile to node version 16 6366307229 / Create subscriptions table * Add subscription entity This will hold any subscriotions related to Bloom. For now, this will be whatsapp but in the future, we may also have email subscriptions. 6366307229 / Create subscriptions table * Create user subscription table This will hold information on the subscriptions a user has. It will also hold information on when a subscription was cancelled. 882f38dfea / Create user subscriptions table * Add migration to create subscription user table 882f38dfea / Create user subscriptions table * Add test fixes 882f38dfea / Create user subscriptions table
Merge to bring in whatsapp subscription endpoint to main
These were missed out in the original migration which created subscription tables.
The base entity which brings in the createdAt and updatedAt fields automatically has now been renamed to base bloom entity. This prevents the type orm base entity from being imported by mistake when the intention is to import the bloom base entity. 5bc71b407d
Merge develop to main
Merge develop into main
Merge develop to main
Merge Develop into Main
6b935e1bc5 / Add verification for whatsapp endpoints
Add logging and add status enum for when subscription already exists. Also added number sanitization to the service. This prevents numbers with white spaces being accepted by the whatsapp endpoint. 6b935e1bc5 / Add verification for whatsapp endpoints
6b935e1bc5 / Add verification for whatsapp endpoints
6b935e1bc5 / Improvements for whatsapp backend
6b935e1bc5 / Improvements for whatsapp backend
Once a subscription is created, the created object is then used to retrieve the full subscription info. This includes the subscription name. This will allow the front end to parse different subscriptions as needed. 6b935e1bc5 / Improvements for whatsapp backend
This will allow the front end to parse different subscriptions as needed. 6b935e1bc5 / Improvements for whatsapp backend
6b935e1bc5 / Improvements for whatsapp backend
Create new course user if missing
Update error status code to 401 when ID token expired
Update partner-access table to remove unique user constraint
Merge Develop onto Main
Release therapy email case sensitivity fix, cypress delete user route and better error handling
Release new logging & dependency updates
Update therapy session table to handle null & fix issue with session completion
Merge Develop onto Main
Merge Develop into main
Merge Dev onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
Merge Develop onto Main
|
@annarhughes @eleanorreem @swetha-charles @kyleecodes Hi! Could you please review this PR? |
|
Hi @reidn3r, I've pinged devs for review. |
|
Hi @kyleecodes, Thank you for the feedback and for pinging the developers for review! I made the necessary changes and created a new Pull Request from the develop branch. You can find it here. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These change tries to solve the issue #454