Diagnose capability changes if migrating between kernels of different cap_last_cap. #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2200 +/- ##
============================================
- Coverage 70.35% 70.30% -0.06%
============================================
Files 133 132 -1
Lines 34001 33995 -6
============================================
- Hits 23923 23900 -23
- Misses 10078 10095 +17
☔ View full report in Codecov by Sentry. |
avagin
reviewed
Jun 16, 2023
osctobe
changed the title
osctobe
force-pushed
the
cap-restore-fix
branch
5 times, most recently
from
0f83a62
to
9f323ad
Compare
avagin
reviewed
Jul 3, 2023
nit: pls remove these Change-Id tags. |
osctobe
force-pushed
the
cap-restore-fix
branch
2 times, most recently
from
dd3691d
to
17cd778
Compare
avagin
reviewed
Jul 21, 2023
avagin
reviewed
Jul 21, 2023
osctobe
force-pushed
the
cap-restore-fix
branch
4 times, most recently
from
021db4e
to
eef1dda
Compare
…els. When restoring on a kernel that has different number of supported capabilities than checkpoint one, check that the extra caps are unset. There are two directions to consider: 1) dump.cap_last_cap > restore.cap_last_cap - restoring might reduce the processes' capabilities if restored kernel doesn't support checkpointed caps. Warn. 2) dump.cap_last_cap < restore.cap_last_cap - restoring will fill the extra caps with zeroes. No changes. Note: `last_cap` might change without affecting `n_words`. Signed-off-by: Michał Mirosław <[email protected]>
|
Merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log when trying to restore capabilities unknown to the kernel.