Add uv_fs_read() $offset param allowing seeking on open handles #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the uv_fs_read() function signature slightly by adding a new $offset parameter. This allows the same file handle to be reused for multiple reads. Previously the only way to access a section of a file that had already been read was to open a new handle. Old: uv_fs_read(resoruce $loop, zval $fd, long $length, callable $callback) New: uv_fs_read(resoruce $loop, zval $fd, long $offest, long $length, callable $callback) This change represents a minor BC break for existing code using uv_fs_read().
rdlowrey
changed the title
|
+1! |
|
LOL! Didn't notice that but your right, I agree - consistency in that regard makes sense. |
steverhoades
added a commit
to steverhoades/php-uv
that referenced
this pull request
Nov 23, 2014
|
Hope you dont mind but I merged this PR into the libuv 1.0 WIP. |
|
Yeah that's no problem @steverhoades ... Pinging @chobie to see if we can get this PR merged. I know he's busy ... I'm forced to ignore PRs for long periods sometimes because of other work too :) |
|
@chobie How do you feel about merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
uv_fs_read()with a newlong $offsetparameter. This allows the same file handle to be reused for multiple reads. Previously the only way to access a section of a file that had already been read was to open a new handle.Old:
New:
This change represents a minor BC break for existing code using
uv_fs_read().