Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ember/test-helpers v4 as dependency #523

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Aug 27, 2024

No description provided.

@Techn1x
Copy link
Contributor

Techn1x commented Aug 27, 2024

Thanks!

@mkszepp mkszepp merged commit 3ec9bc6 into cibernox:master Aug 27, 2024
18 checks passed
@mkszepp mkszepp deleted the allow-test-helpers-v4 branch August 27, 2024 16:38
@mkszepp
Copy link
Collaborator Author

mkszepp commented Aug 28, 2024

Discovered here and also in eps that test are showing green, but we have a issue with ember 3.28 and 4.4

It looks like we have this issue and need to wait for fix embroider-build/embroider#2075

@mkszepp mkszepp restored the allow-test-helpers-v4 branch August 28, 2024 18:32
mkszepp added a commit that referenced this pull request Aug 28, 2024
mkszepp added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants