-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News + Description #97
base: master
Are you sure you want to change the base?
Conversation
It’s best to change the version number and to update the news file as part of the process of resubmitting the package to CRAN. This is something we can start doing after the datasets from stringr are translated, right? Or you are still checking if there are new datasets that need to be translated? |
I took a look around the book and only found those. But I think I should take a second look! |
Riva, now that we already have the datasets from stringr, I think we can move on with this update and send it to CRAN. What do you think? @rivaquiroga |
Sure! I'll work on that next week |
Thank you so much! |
NEWS.md
Outdated
|
||
* On the dataset `voos`, column `cauda` was renamed to `codigo_cauda`, so it's consistent with the dataset `avioes`. | ||
|
||
* Add Eric Scopinho as co-author. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New authors are not announced on NEWS. This is only for changes that affect how people use the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removed it!
@rivaquiroga is there anything else I need to do in this PR? Thank you!! |
After #92 is accepted, we can add the new datasets in the news file and in the description