Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News + Description #97

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

News + Description #97

wants to merge 6 commits into from

Conversation

beatrizmilz
Copy link
Collaborator

After #92 is accepted, we can add the new datasets in the news file and in the description

@rivaquiroga
Copy link
Member

It’s best to change the version number and to update the news file as part of the process of resubmitting the package to CRAN. This is something we can start doing after the datasets from stringr are translated, right? Or you are still checking if there are new datasets that need to be translated?

@beatrizmilz beatrizmilz marked this pull request as draft November 15, 2023 12:51
@beatrizmilz
Copy link
Collaborator Author

I took a look around the book and only found those. But I think I should take a second look!
I left the PR as a draft!

@beatrizmilz beatrizmilz marked this pull request as ready for review August 8, 2024 21:40
@beatrizmilz
Copy link
Collaborator Author

Riva, now that we already have the datasets from stringr, I think we can move on with this update and send it to CRAN. What do you think? @rivaquiroga

@rivaquiroga
Copy link
Member

Sure! I'll work on that next week

@beatrizmilz
Copy link
Collaborator Author

Sure! I'll work on that next week

Thank you so much!

NEWS.md Outdated

* On the dataset `voos`, column `cauda` was renamed to `codigo_cauda`, so it's consistent with the dataset `avioes`.

* Add Eric Scopinho as co-author.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New authors are not announced on NEWS. This is only for changes that affect how people use the package

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed it!

NEWS.md Outdated Show resolved Hide resolved
@beatrizmilz
Copy link
Collaborator Author

@rivaquiroga is there anything else I need to do in this PR? Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants