add wait command to CliCore and TemplateProcessor

[zhirafovod]

Description

Adds wait command and parameters for init.

Type of Change

• Bug Fix
• New Feature
• Breaking Change
• Refactor
• Documentation
• Other (please describe)

Checklist

• I have read the contributing guidelines
• Existing issues have been referenced (where applicable)
• I have verified this change is not present in other open pull requests
• Functionality is documented
• All code style checks pass
• New code contribution is covered by automated tests
• All new and existing tests pass

[geoffhendrey]

I am not sure this is the right approach. I try to wrap functions in safe() so that I can simply throw error and rely on the framework to catch it and pack it into an {error:{...}} object

[zhirafovod]

I've tried a few different approaches. I like with withErrorHandling to handling calling to an external function, where we don't know the context. In this case, I am handling errors from my own code execution, and I think we can do better with a custom error messages.

[geoffhendrey]

but your custom error message will be used by withErrorHandling. All you need to do is throw an error:

private withErrorHandling(fn) {
        return (...args) => {
            try {
                const result = fn(...args);
                if (result instanceof Promise) {
                    return result.catch(error => {
                        this.logger.error(error.toString());
                        return {
                            "error": {
                                message: error.message,
                                name: error.name,
                                stack: error.stack,
                            }
                        };
                    });
                }
                return result;
            } catch (error) {
                this.logger.error(error.toString());
                return {
                    "error": {
                        message: error.message,
                        name: error.name,
                        stack: error.stack,
                    }
                };
            }
        };
    };

[geoffhendrey]

^^^ see how withErrorHandling preserves these properties. So why don't you just catch(e) and set it's message, and rethrow it?

[geoffhendrey]

but your custom error message will be used by withErrorHandling. All you need to do is throw an error:

private withErrorHandling(fn) {
        return (...args) => {
            try {
                const result = fn(...args);
                if (result instanceof Promise) {
                    return result.catch(error => {
                        this.logger.error(error.toString());
                        return {
                            "error": {
                                message: error.message,
                                name: error.name,
                                stack: error.stack,
                            }
                        };
                    });
                }
                return result;
            } catch (error) {
                this.logger.error(error.toString());
                return {
                    "error": {
                        message: error.message,
                        name: error.name,
                        stack: error.stack,
                    }
                };
            }
        };
    };

[geoffhendrey]

^^^ see how withErrorHandling preserves these properties. So why don't you just catch(e) and set it's message, and rethrow it?

[geoffhendrey]

waitCondition and timeout arguments should have types. Return type should be explicit. Whenever we add a new method we should try to use TS best practices.

[geoffhendrey]

originalDefaultFunctions = [...TemplateProcessor.DEFAULT_FUNCTIONS]
If you don't do this you are still allowing the content of DEFAULT_FUNCTIONS array to be destroyed

[geoffhendrey]

don't need to replace subscribe and publish with empty functions anymore