Move citation-number test that depend on off-spec behavior to off-spec folder (v2)
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test were modified in the past so they no longer match their names
|
This adds a couple tiny changes where I simply added the |
|
For whatever reason, I still couldn't rebase (maybe because you had a merge commit?), but I was able to squash it all. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Re-PR’d from branch (compare #64)]
Per conversation in #53 (comment)
Tests that show a reversed
citation-numberdepend on overloaded behavior not defined in the specification. I left in placecitation-numbertests that show an ascendingcitation-number. I think those are basically no-ops anyway.I considered updating
processor.pywith an argument to optionally include this folder but I’m not sure how often it’s used. It didn’t look like it was updated for theprocessor-tests/humans/experimentsfolder so maybe not needed.