v2 #11
Merged
v2 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djfhe
force-pushed
the
next
branch
2 times, most recently
from
95966a7
to
c4f0a68
Compare
|
@saibotk u can already take a look if you want. |
saibotk
requested changes
Aug 18, 2024
saibotk
requested changes
Aug 18, 2024
saibotk
requested changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3
fix #4
fix #5
fix #30
fix #34
Partially fixes #2
We use the currently given path (typed by the user) as an offset to only show the next 3 level deep properties. This improves performance and removes the need for a custom implementation (except the user wants to see deeper by default).
We now also handle read only and union properties correctly.