[Workers] Preview URL updates #18173
Draft
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
github-actions
bot
assigned GregBrimble, irvinebroque, mikenomitch, ToriLindsay, dario-piotrowicz, penalosa and petebacondarwin
Deploying cloudflare-docs with
|
| Latest commit: |
b4f7e53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://86e98476.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://walshy-preview-url-updates.cloudflare-docs-7ou.pages.dev |
taylorlee
reviewed
Nov 15, 2024
|
|
||
| ### Disable in Wrangler | ||
|
|
||
| In your `wrangler.toml` you can add `preview_urls = false` to disable preview URLs from generating and being accessible. |
There was a problem hiding this comment.
They are still generated when off, so we should probably shorten to just "being accessible."
taylorlee
reviewed
Nov 15, 2024
| ```toml | ||
| name = "my-worker" | ||
| compatibility_date = "2024-01-01" | ||
| preview_urls = false |
There was a problem hiding this comment.
trigger-deploy (or regular deploy) is required for this to take effect, probably worth mentioning? We don't make it super obvious that workers_dev isn't synced until trigger-deploy/deploy, as we only specifically say that for disablement: https://developers.cloudflare.com/workers/configuration/routing/workers-dev/#disabling-workersdev
speaking of which, that link's mention of preview-urls is now outdated.
taylorlee
reviewed
Nov 15, 2024
|
|
||
| ### Disable on the Cloudflare dashboard | ||
|
|
||
| TODO: Not finished this yet |
There was a problem hiding this comment.
Looks great so far! Ping me when ready for rereview :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots (optional)
Documentation checklist