Rename Compatibility Dates to Compatibility Flags #18176
+31
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
requested review from
irvinebroque,
mikenomitch,
GregBrimble,
a team,
WalshyDev,
ToriLindsay,
KianNH,
pedrosousa,
kristianfreeman,
haleycode,
maxvp and
marciocloudflare
as code owners
2 tasks
github-actions
bot
assigned dcpena, haleycode, patriciasantaana, pedrosousa, GregBrimble, KianNH, WalshyDev, kristianfreeman, marciocloudflare and maxvp
Deploying cloudflare-docs with
|
| Latest commit: |
4d06ca1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30f227f3.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://compatflags.cloudflare-docs-7ou.pages.dev |
|
Checks:
/cc @ToriLindsay that should cover what we discussed offline. Thanks for the help. |
Rename: - Component: CompatibilityDates -> CompatibilityFlags - Files - Collection: compatibility-dates -> compatibility-flags - Schema: CompatibilityDatesSchema -> CompatibilityFlagsSchema Update: - CODEOWNERS - Redirect: https://developers.cloudflare.com/workers/platform/compatibility-dates.json -> compatibility-flags.json
|
rebased |
ToriLindsay
approved these changes
Nov 18, 2024
| @@ -1449,6 +1449,7 @@ | |||
| /workers/platform/triggers/cron-triggers/ /workers/configuration/cron-triggers/ 301 | |||
| /workers/platform/cron-triggers/ /workers/configuration/cron-triggers/ 301 | |||
| /workers/platform/compatibility-dates/ /workers/configuration/compatibility-dates/ 301 | |||
| /workers/platform/compatibility-dates.json /workers/platform/compatibility-flags.json 301 | |||
There was a problem hiding this comment.
Suggested change
| /workers/platform/compatibility-dates.json /workers/platform/compatibility-flags.json 301 | |
| /workers/platform/compatibility-dates/ /workers/platform/compatibility-flags/ 301 |
@vicb Just confirming that it shouldn't like this instead? Feel free to close this suggestion if not. Let me know if you're not sure and I'll find out.
There was a problem hiding this comment.
No.
The only path changed by this PR is the json file, see #18176 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename:
Update:
Details
Follow up for #17900
The name "Compatibility Dates" probably comes from the fact that there was no "Compatibility Flags" section prior ro #17900. However the collection and the component list flags, not dates.
Documentation checklist