-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs]: update field reference #18177
base: production
Are you sure you want to change the base?
[Logs]: update field reference #18177
Conversation
This also switches the files from `.mdx` back to `.md` since using MDX causes us to have to escape all the `[`, `{` and `<` characters during generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20 files reviewed, 6 total issue(s) found.
|
||
Transport protocol used by client; <em>tcp</em> | <em>udp</em> | <em>unix</em>. | ||
Transport protocol used by client; <em>tcp</em> \| <em>udp</em> \| <em>unix</em>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transport protocol used by client; <em>tcp</em> \| <em>udp</em> \| <em>unix</em>. | |
Transport protocol used by client; <em>tcp</em> \| <em>UDP</em> \| <em>UNIX</em>. |
Issues:
- Style Guide - (Terms-error) Use 'UDP' instead of 'udp'.
- Style Guide - (Terms-error) Use 'UNIX' instead of 'unix'.
Fix Explanation:
The terms 'UDP' and 'UNIX' should be capitalized according to standard style guides for technical documentation. This change ensures consistency and adheres to the style guide requirements.
|
||
Transport protocol used by origin; <em>tcp</em> | <em>udp</em> | <em>unix</em>. | ||
Transport protocol used by origin; <em>tcp</em> \| <em>udp</em> \| <em>unix</em>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transport protocol used by origin; <em>tcp</em> \| <em>udp</em> \| <em>unix</em>. | |
Transport protocol used by origin; <em>tcp</em> \| <em>UDP</em> \| <em>UNIX</em>. |
Issues:
- Style Guide - (Terms-error) Use 'UDP' instead of 'udp'.
- Style Guide - (Terms-error) Use 'UNIX' instead of 'unix'.
Fix Explanation:
The terms 'UDP' and 'UNIX' should be capitalized to adhere to standard style guidelines. This change ensures consistency and clarity in the documentation.
|
||
Type: `string` | ||
|
||
Phase of the HTTP request this forensic copy was captured from (i.e. "request" or "response"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phase of the HTTP request this forensic copy was captured from (i.e. "request" or "response"). | |
Phase of the HTTP request from which this forensic copy was captured (that is, "request" or "response"). |
Issues:
- Style Guide - (cloudflare.LatinTerms-warning) Use 'that is' instead of 'i.e.', but consider rewriting the sentence.
Fix Explanation:
The use of 'i.e.' is discouraged in some style guides in favor of 'that is' for clarity. Additionally, I rephrased the sentence slightly to improve readability by moving 'from' earlier in the sentence. This makes the sentence more direct and clear.
|
||
The type of destination to which the network session was routed. <br />Possible values are <em>INTERNET</em> | <em>MAGIC</em> | <em>CFD\_TUNNEL</em> | <em>WARP</em>. | ||
The type of destination to which the network session was routed. <br />Possible values are <em>INTERNET</em> \| <em>MAGIC</em> \| <em>CFD_TUNNEL</em> \| <em>WARP</em>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of destination to which the network session was routed. <br />Possible values are <em>INTERNET</em> \| <em>MAGIC</em> \| <em>CFD_TUNNEL</em> \| <em>WARP</em>. | |
The type of destination to which the network session was routed. <br />Possible values are <em>Internet</em> \| <em>MAGIC</em> \| <em>CFD_TUNNEL</em> \| <em>WARP</em>. |
Issues:
- Style Guide - (Terms-error) Use 'Internet' instead of 'INTERNET'.
Fix Explanation:
The term 'INTERNET' should be replaced with 'Internet' to comply with the style guide and improve readability. The rest of the line remains unchanged as it is correct.
|
||
The layer 4 protocol of the packet which triggered the detection. Possible values are <em>tcp</em> | <em>udp</em> | <em>any</em>. Variant <em>any</em> means a detection occurred at a lower layer (such as IP). | ||
The layer 4 protocol of the packet which triggered the detection. Possible values are <em>tcp</em> \| <em>udp</em> \| <em>any</em>. Variant <em>any</em> means a detection occurred at a lower layer (such as IP). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layer 4 protocol of the packet which triggered the detection. Possible values are <em>tcp</em> \| <em>udp</em> \| <em>any</em>. Variant <em>any</em> means a detection occurred at a lower layer (such as IP). | |
The layer 4 protocol of the packet which triggered the detection. Possible values are <em>tcp</em> \| <em>UDP</em> \| <em>any</em>. Variant <em>any</em> means a detection occurred at a lower layer (such as IP). |
Issues:
- Style Guide - (Terms-error) Use 'UDP' instead of 'udp'.
Fix Explanation:
The style guide specifies that protocol names should be in uppercase, so 'udp' should be changed to 'UDP'. This is a straightforward style correction.
|
||
The outcome of the worker script invocation. <br />Possible values are <em>ok</em> | <em>exception</em>. | ||
The outcome of the worker script invocation. <br />Possible values are <em>ok</em> \| <em>exception</em>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The outcome of the worker script invocation. <br />Possible values are <em>ok</em> \| <em>exception</em>. | |
The outcome of the Worker script invocation. <br />Possible values are <em>ok</em> \| <em>exception</em>. |
Issues:
- Style Guide - (Terms-error) Use 'Worker' instead of 'worker'.
Fix Explanation:
The term 'Worker' should be capitalized according to the style guide. This change ensures consistency and adherence to the specified guidelines.
Just fyi, when you create a PR based on the branch in this repo directly, it would create a preview, which is quite helpful when reviewing, but when it's based on a forked repo, it won't. |
Since these pages are generated I think we can disregard hyperlint suggestions. If we think they are relevant we can later address them in the source files. |
@KianNH if you don't have any concerns with this update, for me it's ok to merge. |
Summary
This also switches the files from
.mdx
back to.md
since using MDX causes us to have to escape all the[
,{
and<
characters during generation.Screenshots (optional)
Documentation checklist