Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax version constraints for vitest #18227

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Relax version constraints for vitest #18227

wants to merge 1 commit into from
+1 −7

Conversation

ocavue
Copy link

@ocavue ocavue commented Nov 17, 2024

Summary

@cloudflare/vitest-pool-workers supports the latest v2.1.x in this PR (cloudflare/workers-sdk#6716), so it might be a good idea to relax the version constraints in the documents too.

Screenshots (optional)

N/A

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions github-actions bot added the product:workers Related to Workers product label Nov 17, 2024
@ocavue ocavue marked this pull request as ready for review November 17, 2024 22:16
@GregBrimble
Copy link
Member

@penalosa , thoughts on this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@ToriLindsay ToriLindsay Awaiting requested review from ToriLindsay ToriLindsay is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@ToriLindsay ToriLindsay

Labels
product:workers Related to Workers product size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ocavue @GregBrimble @irvinebroque @mikenomitch @WalshyDev @ToriLindsay