Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-arch builds for local development #3485

Merged

Conversation

pbusko
Copy link
Contributor

@pbusko pbusko commented Sep 19, 2024

Is there a related GitHub Issue?

no

What is this change about?

hardcoded GOARCH prevents local testing with kind when using ARM64 machine

Does this PR introduce a breaking change?

no

Acceptance Steps

Tag your pair, your PM, and/or team

@danail-branekov
Copy link
Member

@pbusko Just out of curiosity - have you tried running deploy-on-kind on a non-amd64 architecture?

@pbusko
Copy link
Contributor Author

pbusko commented Sep 19, 2024

@pbusko Just out of curiosity - have you tried running deploy-on-kind on a non-amd64 architecture?

It does work with noticeable performance degradation for emulated components, like Korifi API/Controllers and kpack. We're also working on bringing native arm64 support for kpack.
Some colleagues even reported issue when running ./scripts/deploy-on-kind.sh on certain VMs, with fork/exec errors highlighting architecture mismatch, failing local setup completely

@georgethebeatle georgethebeatle merged commit 96c77ac into cloudfoundry:main Sep 19, 2024
11 checks passed
@georgethebeatle
Copy link
Member

Thanks @pbusko

@pbusko pbusko deleted the support-arm64-kind branch September 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants