Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbox #162

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Workbox #162

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
18c6474
Replace sw libs with workbox
calebeby Jul 11, 2018
2cf3853
Remove unused npm scripts
calebeby Jul 11, 2018
c3ddf42
Change sw url in html template
calebeby Jul 11, 2018
5e45aa7
Log errors for service worker installation problems
calebeby Jul 12, 2018
ed0deec
Merge remote-tracking branch 'origin/master' into feature/workbox
calebeby Jul 16, 2018
60fa5ee
Do not cache opaque responses
calebeby Jul 16, 2018
1faf350
Fallback to 404 page for html files
calebeby Jul 16, 2018
a9b1d82
Delete unrecognized caches
calebeby Jul 16, 2018
5ec46cc
Single quote, semicolon in blank.html file
calebeby Jul 17, 2018
b6bf3b2
Automatically start workbox/replace old service workers
calebeby Jul 17, 2018
bd0b3a4
Add precaching to service worker, with 404 fallback
calebeby Jul 17, 2018
cc0fbbc
Merge remote-tracking branch 'origin/master' into feature/workbox
calebeby Jul 17, 2018
7df3c6d
Empty commit to trigger netlify build again
calebeby Jul 17, 2018
46e535e
Fix: copy revisioned service worker to dist
calebeby Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion _layouts/blank.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
{% include svg-icons.html %}
<script>
if ('serviceWorker' in navigator) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are making changes, can me add a friendly console warning message if service workers are not supported?

Something like:

if ('serviceWorker' in navigator) {
  // ...
} else {
  console.warn('Service workers are not supported by this browser. :(');
}

navigator.serviceWorker.register('/sw.js');
navigator.serviceWorker.register('/sw.js').catch(e => console.error("Problem installing service worker:", e));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Single quote for consistency? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

} else {
console.log('Your browser does not support service workers :(')
}
</script>
</body>
Expand Down
23 changes: 0 additions & 23 deletions js/vendor/sw-cacheable-response.min.js
View file
Open in desktop

This file was deleted.

Loading