Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cluster): Add replication slots configuration #356

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dragoangel
Copy link
Contributor

implements: #354

@dragoangel dragoangel force-pushed the feature/add-replication-slots-conf branch 2 times, most recently from 778ac48 to 086347f Compare August 26, 2024 11:06
@itay-grudev itay-grudev added the chart( cluster ) Related to the cluster chart label Aug 26, 2024
@dragoangel dragoangel force-pushed the feature/add-replication-slots-conf branch from 086347f to 4cd6453 Compare August 26, 2024 19:24
charts/cluster/Chart.yaml Outdated Show resolved Hide resolved
Comment on lines 159 to 163
replicationSlots:
highAvailability:
enabled: true
slotPrefix: _cnpg_
updateInterval: "30"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace this with:

  replicationSlots: {}
   # highAvailability:
   #   enabled: true
   #   slotPrefix: _cnpg_
   #   updateInterval: "30"

and then re-run make schema docs.

Otherwise the generated schema is incorrect and would not allow otherwise valid configurations. This way it would only validate whether it's passed an object.

Copy link
Contributor Author

@dragoangel dragoangel Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I not get a bit what you mean. This will be this way, what else can be set outside of this schema?

I specially set highAvailability, as it always has place even when it unset in CRD, it just turned on by default with this settings.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@itay-grudev itay-grudev Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that our schema is auto generated based on values, so it will assume the structure you provided, which is incomplete. Run make schema.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found and fixed issue, thanks

@dragoangel dragoangel force-pushed the feature/add-replication-slots-conf branch from 4cd6453 to e88e0af Compare August 31, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( cluster ) Related to the cluster chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants