conf.py: Update year in footer #587
Conversation
sambhavkaul
changed the title
There was a problem hiding this comment.
@sambhavkaul just one suggestion never make a PR from your master, always checkout a new branch from the master for a particular issue and keep your master clean. Make sure you read Commit Guidelines.
you should keep this best practice in mind so that you are able to work on multiple PRs simultaneously in the future.
There was a problem hiding this comment.
In the commit message, ... automatically Update the .., update shouldn't start with a capital 'U'.
Apart from that the changes look good but avoid working on the master branch from the next time and create a new branch for your changes and PR.
EDIT: the master branch part was just covered by bharatpurohit97, so that's repetitive.
|
@shashank-b I have changed the commit message, please see to it now. Thank you for telling, i'll be careful next time. |
|
@bharatpurohit97 Thank you for the suggestion. Yes absolutely i'll take care of branches from next time. Should I close this PR and make a new one with a different branch ? |
|
@sambhavkaul it can be overlook for now i guess, avoid working from next time. |
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
This will automatically update the year in footer. Closes coala#582
|
Automated rebase with GitMate.io was successful! 🎉 |
This will automatically update the year in footer.
Closes #582
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!