Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multi-cause error support compatible with go versions before 1.20 #122

Closed

Conversation

dhartunian
Copy link
Contributor

@dhartunian dhartunian commented Aug 23, 2023

This commit also reverts go.mod to use 1.18 to match the state of the
codebase from before the go 1.20 upgrade.

This allows older codebases to upgrade to a version of this library
that can encode/decode multi-cause errors from newer versions without
completely discarding the child cause error info.


This change is Reviewable

@dhartunian dhartunian changed the base branch from master to go-1.18-compat August 24, 2023 20:14
@dhartunian dhartunian changed the title [WIP] Go 1.18 compat Make multi-cause changes compatible with go versions before 1.20 Aug 24, 2023
@dhartunian dhartunian changed the title Make multi-cause changes compatible with go versions before 1.20 Make multi-cause error support compatible with go versions before 1.20 Aug 24, 2023
This commit also reverts go.mod to use 1.18 to match the state of the
codebase from before the go 1.20 upgrade.

This allows older codebases to upgrade to a version of this library
that can encode/decode multi-cause errors from newer versions without
completely discarding the child cause error info.
@dhartunian
Copy link
Contributor Author

Closing since I made a mistake. We need to revert to go 1.17, not 1.18

@dhartunian dhartunian closed this Aug 24, 2023
@dhartunian dhartunian deleted the go-1.18-compat branch August 24, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant