Downgrade go version requirement to 1.19 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knz
reviewed
Aug 28, 2023
| strategy: | ||
| matrix: | ||
| go: | ||
| - "1.19" |
There was a problem hiding this comment.
- maybe check if we could preserve compat with 1.18 here
- I think the matrix can still include 1.20?
Previously, we had upgraded this library to be compatible with a number of features introduced in go 1.20. Our compatibility with the multi-cause errors does not depend on those features being available in the stdlib so the requirement in go.mod is being downgraded to 1.19. This removes the need for an older compatibility branch released as version 1.10.1 of this library. Go 1.20 features are only necessary to run tests. GitHub actions are adjusted to additionally test for a successful build on 1.19.
dhartunian
force-pushed
the
downgrade-go-requirement-to-1.19
branch
from
aa2683b
to
fe94800
Compare
knz
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had upgraded this library to be compatible with a number of features introduced in go 1.20. Our compatibility with the multi-cause errors does not depend on those features being available in the stdlib so the requirement in go.mod is being downgraded to 1.19.
This removes the need for an older compatibility branch released as version 1.10.1 of this library.
Go 1.20 features are only necessary to run tests. GitHub actions are adjusted to additionally test for a successful build on 1.19.
This change is