New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct example names for HasType and HasInterface #144

Merged

dhartunian merged 1 commit into cockroachdb:master from alexandear:fix/example-name

Jun 3, 2024

Contributor

alexandear commented May 28, 2024 •

edited

Loading

This PR corrects the names of example functions to match the file name:

ExampleIsType is renamed to ExampleHasType as it serves as an example for markers.HasType.
ExampleIsInterface is renamed to ExampleHasInterface as it serves as an example for markers.HasInterface.
markers/example_is_type_test.go is renamed to markers/example_has_type_test.go.

This change is


          Fix example names for HasType and HasInterface

cb2348e

dhartunian approved these changes

View reviewed changes

dhartunian merged commit 5b23426 into cockroachdb:master

6 checks passed

alexandear deleted the fix/example-name branch

June 3, 2024 16:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet