Creator controls and queue management and Fix issue #49 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add back the pnpm-lock |
|
added it back |
hkirat
reviewed
Aug 30, 2024
| const res = await youtubesearchapi.GetVideoDetails(extractedId); | ||
|
|
||
| // Check if the user is not the creator | ||
| if (user.id !== data.creatorId) { |
There was a problem hiding this comment.
I think I added this comment uin the other PR
creator should be able to add unlimited links to the queue
There was a problem hiding this comment.
creator is able to add unlimited links to the queue, only a normal user is rate limited
There was a problem hiding this comment.
Only applying rate limits and duplicity checks for !creator
hkirat
reviewed
Aug 30, 2024
|
Tag me for review when done @Bot-Rakshit |
|
@hkirat good for review, LGTM |
|
this pr also solves #49 |
Bot-Rakshit
changed the title
hkirat
reviewed
Aug 31, 2024
Bot-Rakshit
commented
Aug 31, 2024
| } catch(e) { | ||
|
|
||
| const res = await fetch("/api/streams/empty-queue", { | ||
| method: "POST" |
There was a problem hiding this comment.
have used it here @hkirat
|
/bounty $100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Description:
Added creator-specific controls:
Implemented an "Empty Queue" button for creators
Added a confirmation dialog for emptying the queue
Creators can now remove individual songs from the queue
Added rate limiting( not for creators):
Normal users will get rate limited, they can add only 2 songs per 2 minutes, and 5 songs in 10 minutes ( can be changed according to connivence)
3.Avoided Duplicate songs ( not for creators)
if the same song has been added in the last 10 minutes it throws an error to the user.