Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Relax the version constraint to support simplecov 0.22 #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knu
Copy link

@knu knu commented Jan 5, 2023

simplecov 0.22 has been released and this gem needs to support it.

Currently, updating simplecov 0.22 requires codecov to go back to 0.2.12 which happened to have no upper bound in the version constraint. Here's a hunk of Gemfile.lock included in the PR I received from dependabot.

-    codecov (0.6.0)
-      simplecov (>= 0.15, < 0.22)
+    codecov (0.2.12)
+      json
+      simplecov

Then codecov 0.2.12 failed to upload coverage data with the configuration that works with 0.6.0. (Bad URI error)

@height
Copy link

height bot commented Jan 5, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@AlexWayfer
Copy link
Contributor

Although I'm not against, I believe this repo is deprecated: 5c516a7

And we should use shell uploader: https://docs.codecov.com/docs/codecov-uploader

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants