Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mix: reimplement based on std::lerp reference implementation. #219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hvdijk
Copy link
Collaborator

@hvdijk hvdijk commented Nov 17, 2023

Overview

mix: reimplement based on std::lerp reference implementation.

Reason for change

The referenced paper explains the problems with various other implementations of lerp/mix, including ours.

Description of change

An implementation of mix is used that follows std::lerp.

Anything else we should know?

This change will make us fail the SYCL CTS, because of problematic testing in the SYCL CTS. I am opening up an issue against SYCL CTS about that. Hopefully they agree.

Checklist

  • Read and follow the project Code of Conduct.
  • Make sure the project builds successfully with your changes.
  • Run relevant testing locally to avoid regressions.
  • Run clang-format-16 (the most
    recent version available through pip) on all modified code.

The referenced paper explains the problems with various other
implementations of lerp/mix, including ours.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants