Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap lifespan decorator in docs and add missing type #1362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inktrap
Copy link

@inktrap inktrap commented Jun 20, 2024

This is my solution for #1361 if you like it feel free to merge.

@inktrap
Copy link
Author

inktrap commented Jun 20, 2024

I guess the test in docs_src/fastapi/docs001.py needs some changes too?

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9701e69) to head (3e6c61e).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1362   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       206           
  Lines        14940     14940           
=========================================
  Hits         14940     14940           

Copy link

codspeed-hq bot commented Jun 26, 2024

CodSpeed Performance Report

Merging #1362 will degrade performances by 23.88%

Comparing inktrap:master (3e6c61e) with master (81bb434)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 82 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master inktrap:master Change
test_sum[500] 3.2 ms 2.7 ms +17.3%
test_first[1000] 3.1 ms 4.1 ms -23.88%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant