Nissan: Add fingerprint for 2020 Altima

[JtMotoX]

add missing fingerprint for 2020 Altima

route: 8864973010c8382c/00000000--ce17b8b109

[github-actions]

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • include a route or your device' dongle ID if relevant

[jyoung8607]

We shouldn't really add any more CAN fingerprints unless we have to, we should add UDS firmware fingerprints. See fingerprinting 2.0:

https://github.com/commaai/openpilot/wiki/Fingerprinting

If you're not seeing UDS fingerprint data you're otherwise having trouble, let us know here or reach out on Discord.

[JtMotoX]

From what I can tell, the FW info pulled from my logs (snippet below) matches what is already in the fingerprints.py, however, openpilot said my car is unsupported and was put in dashcam mode. Once I added the CAN fingerprints, openpilot recognized the car and allowed me to calibrate and use it.

'carFw': [{'address': 1799,
          'brand': 'nissan',
          'bus': 0,
          'ecu': 'fwdCamera',
          'fwVersion': b'284N86CA1D',
          'logging': False,
          'obdMultiplexing': True,
          'request': [b'"\xf1\x88'],
          'responseAddress': 1831,
          'subAddress': 0},
         {'address': 1858,
          'brand': 'nissan',
          'bus': 1,
          'ecu': 'eps',
          'fwVersion': b'6CA2B\xa9A\x02\x02G8A89P90D6A\x00\x00\x01\x80',
          'logging': True,
          'obdMultiplexing': True,
          'request': [b'\x10\x81', b'!\x83'],
          'responseAddress': 1890,
          'subAddress': 0},
         {'address': 416993521,
          'brand': 'nissan',
          'bus': 1,
          'ecu': 'gateway',
          'fwVersion': b'284U29HE0A',
          'logging': True,
          'obdMultiplexing': True,
          'request': [b'"\xf1\x88'],
          'responseAddress': 417001936,
          'subAddress': 0},
         {'address': 1799,
          'brand': 'nissan',
          'bus': 1,
          'ecu': 'fwdCamera',
          'fwVersion': b'284N86CA1D',
          'logging': True,
          'obdMultiplexing': True,
          'request': [b'"\xf1\x88'],
          'responseAddress': 1831,
          'subAddress': 0},
         {'address': 2016,
          'brand': 'ford',
          'bus': 1,
          'ecu': 'engine',
          'fwVersion': b'237109HE2B',
          'logging': True,
          'obdMultiplexing': True,
          'request': [b'>\x00', b'"\xf1\x88'],
          'responseAddress': 2024,
          'subAddress': 0}],
'carName': 'mock',

[jyoung8607]

Indeed all of those entries are present. One of the queries is coming back tagged as Ford, but I'm not sure if that's the problem.

I'll need to see the route to dig into it further. The route ID you gave above isn't marked public. If you can mark it public, or make another route that you're willing to mark public if that one contains privacy relevant locations, I'll take a look. We'll get support merged one way or another.

[JtMotoX]

Here is a public route from OP master which did not detect the car.

8864973010c8382c/0000000b--f0fc564584

[github-actions]

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.