Bump six and requests dependency versions #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwltool itself doesn't depend on six 1.9.0, but prov does, and having matching dependencies helps Pip find a correct set of packages to install (see common-workflow-language#872).
cwltool itself doesn't depend on requests 2.6.1, but CacheControl does, and having matching dependencies helps Pip find a correct set of packages to install (see common-workflow-language#872).
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
=========================================
+ Coverage 72.61% 72.8% +0.18%
=========================================
Files 34 34
Lines 6401 6401
Branches 1617 1617
=========================================
+ Hits 4648 4660 +12
+ Misses 1305 1295 -10
+ Partials 448 446 -2
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cwltool itself doesn't require these versions, but its dependencies do.
Since Pip doesn't have a backtracking dependency resolver yet, it can fail to find a correct solution if the package being installed has low requirements that are already installed, but a dependency has a higher requirement. For example, cwltool requires six 1.8.0, but prov requires six 1.9.0; Debian Jessie packages six 1.8.0, so
pip install cwltoolsees that the installed six meets cwltool's requirements, but it isn't able to determine that it should install a newer version of six once it scans prov's dependencies. (More recent versions of Pip will at least print a warning in this case.)The Requests version bump is to work around an issue with old Requests versions and CacheControl (psf/cachecontrol#137).
See #872.