Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some compiler compatibility checks #498

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

compnerd
Copy link
Contributor

stdbool.h is part of C99 however was not provided by Visual Studio 2013 until RTM [1]. Remove the check for the header and inline the include at the usage sites rather than relying on config.h. VS2013 was EOL'ed Apr 9, 2019, with extended support ending Apr 9, 2024.

HAVE___ATTRIBUTE__ was unused in the codebase and served no purpose.

Remove shims for snprintf and vsnprintf which were unavailable prior to VS2015. As VS2013 is no longer serviced, this reduces complexity in the project.

[1] https://devblogs.microsoft.com/cppblog/c99-library-support-in-visual-studio-2013/

src/buffer.c Outdated Show resolved Hide resolved
@jgm
Copy link
Member

jgm commented Dec 29, 2023

HAVE___ATTRIBUTE__ was unused in the codebase and served no purpose.

@nwellnhof do you remember what this was for?

@nwellnhof
Copy link
Contributor

No idea. Looks useless.

`stdbool.h` is part of C99 however was not provided by Visual Studio
2013 until RTM [1]. Remove the check for the header and inline the
include at the usage sites rather than relying on `config.h`.  VS2013
was EOL'ed Apr 9, 2019, with extended support ending Apr 9, 2024.

`HAVE___ATTRIBUTE__` was unused in the codebase and served no purpose.

Remove shims for `snprintf` and `vsnprintf` which were unavailable prior
to VS2015.  As VS2013 is no longer serviced, this reduces complexity in
the project.

[1] https://devblogs.microsoft.com/cppblog/c99-library-support-in-visual-studio-2013/
@jgm jgm merged commit 7daaeb0 into commonmark:master Dec 29, 2023
12 checks passed
@compnerd compnerd deleted the vs2013 branch December 29, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants