-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uvicorn-tschaume #21051
Add uvicorn-tschaume #21051
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/uvicorn-tschaume:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@dopplershift I changed the recipe to |
How does this one compare with the official? https://pypi.org/project/uvicorn/ |
It is basically a build of encode/uvicorn#947 for more details: materialsproject/emmet@9131828#r89153314 |
It appears this fork is bypassing upstream which wants the feature but is moving more slowly. This is a pretty bad dev practice even if the intent is to switch eventually. IDK if were should be merging recipes like this. Thoughts? |
That is also fine with me. |
FWIW in situations like this in the past, I've often built my own package with the needed feature/bug fix and stuck it in my own channel. Then whenever the needed changes are included in the upstream package, I can drop my own build of it. For really simple changes, some vendored or backport code in whatever library uses it could work. Maybe these approaches are worth considering |
Good ideas @jakirkham! Both approaches you mention are better than a new feedstock for a temporary fork. |
My issue is that conda-forge/emmet-api-feedstock#17 requires |
You can always talk to the maintainers about their intentions. 🤷 |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).