Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud events json schema #1105

Open
wants to merge 3 commits into
base: 7.1.1-post
Choose a base branch
from

Conversation

1123
Copy link

@1123 1123 commented May 31, 2022

Description

This pull request adds an example for writing data respecting the Cloud Events Standard to Confluent Cloud, and registering the corresponding schema with Confluent Schema Registry. It is a somewhat minimal example for this requirement and independent of the other client samples in this repository.

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

[x] Documentation: This sample comes with its own README.md file. Not sure if it needs to be documented elsewhere.
[x] clients/cloud: This is the directory where the sample has been added. It could be moved to another directory if needed. It should work just as well with an on-premise cluster.

This pull request does not touch any of the other sample programs, and thus should not affect their functionality.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

@ybyzek
Copy link
Contributor

ybyzek commented May 31, 2022

@1123 thanks for the PR.

  1. The examples in the clients/cloud/ folder are for languages, not specifications. A better location may be to put this in clients/ in a new subfolder called cloudevents/?
  2. Should there be a consumer example?
  3. If there isn't already, perhaps there should be a link added from docs.confluent.io
  4. Please recommend another reviewer who is familiar with CloudEvents, who can review this PR from that perspective.

Copy link

cla-assistant bot commented Apr 28, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants