Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count characters in password example instead of bytes #276

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

Gordon01
Copy link
Contributor

@Gordon01 Gordon01 commented Sep 5, 2023

A password example contains a typical Rust bug when String's number of bytes is checked instead of characters.

Password::interact_on() doc is updated here too.

Copy link
Collaborator

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the examples in docs for password validation too.

@Gordon01
Copy link
Contributor Author

Gordon01 commented Sep 6, 2023

Done

@pksunkara pksunkara merged commit af5f522 into console-rs:master Sep 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants