ensure console socket buffers are properly sized #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GIven that this is not a problem on Linux which defaults to much larger buffers, the calls to setsockopt could be made conditional for FreeBSD builds. |
yeah I think I would prefer that |
dfr
force-pushed
the
freebsd-console-buffers
branch
from
a3e4419
to
386d23b
Compare
|
This iteration factors out setting the socket buffers and makes it a no-op on Linux. |
On FreeBSD, the default socket buffer size for unix domain sockets is just 8192 which is too small for largest message used on the console socket which is 8193. This causes output for processes which emit large amounts of data to be lost on FreeBSD (for an example, see podman's 'podman exec/run - missing output' system test). To avoid the problem, this commit increases the buffer sizes to CONN_SOCK_BUF_SIZE (32768) which allows for several max-sized messages to be in-flight. Signed-off-by: Doug Rabson <[email protected]>
dfr
force-pushed
the
freebsd-console-buffers
branch
from
386d23b
to
fa67ce6
Compare
|
LGTM |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD, the default socket buffer size for unix domain sockets is just 8192 which is too small for largest message used on the console socket which is 8193. This causes output for processes which emit large amounts of data to be lost on FreeBSD (for an example, see podman's 'podman exec/run - missing output' system test).
To avoid the problem, this commit increases the buffer sizes to CONN_SOCK_BUF_SIZE (32768) which allows for several max-sized messages to be in-flight.