vendor: drop libpod in runner package #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haircommander
force-pushed
the
drop-libpod
branch
4 times, most recently
from
1782ea3
to
e910376
Compare
|
LGTM |
kwilczynski
reviewed
Sep 20, 2024
runner/conmon/pipes.go
Outdated
| // And copied to reduce the vendor surface area of this library | ||
| var ( | ||
| // ErrInternal indicates an internal library error | ||
| ErrInternal = fmt.Errorf("internal libpod error") |
There was a problem hiding this comment.
Would it make sense to rename the error message to:
Suggested change
| ErrInternal = fmt.Errorf("internal libpod error") | |
| ErrInternal = fmt.Errorf("internal error") |
haircommander
force-pushed
the
drop-libpod
branch
from
e910376
to
77cfabf
Compare
Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
drop-libpod
branch
from
77cfabf
to
c5bb51b
Compare
|
/approve |
haircommander
force-pushed
the
drop-libpod
branch
from
c5bb51b
to
cc32751
Compare
Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
drop-libpod
branch
from
cc32751
to
d15057b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially the hope of the runner package was to be a library that podman and cri-o used, but that never happened. now, it's just for tests. As such, we can use different errors and reduce the vendor surface area of conmon