Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AWS uploading image #579

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat: add AWS uploading image #579

merged 1 commit into from
Jun 27, 2024

Conversation

cdrage
Copy link
Collaborator

@cdrage cdrage commented Jun 25, 2024

feat: add AWS uploading image

What does this PR do?

  • Adds the ability to upload to AWS through build
  • Toggled advanced features section

Screenshot / video of UI

Screenshot 2024-06-25 at 3 29 45 PM

What issues does this PR fix or reference?

Closes #487

How to test this PR?

  1. Sign up for a free AWS S3 bucket account
  2. Set very permissive options for S3 bucket for your user (full admin access) so you do not encounter policy issues for testing.
  3. Add your credentials to ~/.aws/credentials
  4. Build your image + provide your bucket, aminame, etc.

Signed-off-by: Charlie Drage [email protected]

@cdrage cdrage requested a review from a team as a code owner June 25, 2024 19:33
@cdrage cdrage marked this pull request as draft June 25, 2024 19:33
@cdrage
Copy link
Collaborator Author

cdrage commented Jun 25, 2024

Encountered osbuild/bootc-image-builder#501 for use against a custom server, so opened up that issue. It does however work with AWS S3.

Tasks:

  • Works with AWS S3
  • Add unit tests.

@cdrage cdrage marked this pull request as ready for review June 26, 2024 14:39
@cdrage
Copy link
Collaborator Author

cdrage commented Jun 26, 2024

Ready for review.. although bit of a chicken and an egg problem. We can get this in, but we would need to rebase and update against #540 , or we wait for #540 and then rebase against that.

Totally fine either way, but there are some hardcoded color files in this PR since they do not match the other current ones when using from color-registry.ts

cc @deboer-tim

@deboer-tim
Copy link
Collaborator

Ready for review.. although bit of a chicken and an egg problem. We can get this in, but we would need to rebase and update against #540 , or we wait for #540 and then rebase against that.

Did you mean rebasing on #576? (as we don't have any other PRs up in this area that would require rebasing and there are several steps to do #540). I don't have an issue with this from a light mode standpoint, as we could easily replace these color values at the same time as fixing the others and it doesn't make sense to do anything else in the meantime.

@cdrage
Copy link
Collaborator Author

cdrage commented Jun 26, 2024

Ready for review.. although bit of a chicken and an egg problem. We can get this in, but we would need to rebase and update against #540 , or we wait for #540 and then rebase against that.

Did you mean rebasing on #576? (as we don't have any other PRs up in this area that would require rebasing and there are several steps to do #540). I don't have an issue with this from a light mode standpoint, as we could easily replace these color values at the same time as fixing the others and it doesn't make sense to do anything else in the meantime.

Ah I mean if we should wait for light mode form to go in first before this PR. If you are good with hardcoded colours (for now), I'm fine with that!

👍

### What does this PR do?

* Adds the ability to upload to AWS through build
* Toggled advanced features section

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#487

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Add your credentials to ~/.aws/credentials
2. Build your image + provide your bucket, aminame, etc.

Signed-off-by: Charlie Drage <[email protected]>
@deboer-tim deboer-tim merged commit a9fe2bd into containers:main Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pushing AMI to S3 bucket
2 participants