-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AWS uploading image #579
Conversation
Encountered osbuild/bootc-image-builder#501 for use against a custom server, so opened up that issue. It does however work with AWS S3. Tasks:
|
Ready for review.. although bit of a chicken and an egg problem. We can get this in, but we would need to rebase and update against #540 , or we wait for #540 and then rebase against that. Totally fine either way, but there are some hardcoded color files in this PR since they do not match the other current ones when using from color-registry.ts cc @deboer-tim |
Did you mean rebasing on #576? (as we don't have any other PRs up in this area that would require rebasing and there are several steps to do #540). I don't have an issue with this from a light mode standpoint, as we could easily replace these color values at the same time as fixing the others and it doesn't make sense to do anything else in the meantime. |
Ah I mean if we should wait for light mode form to go in first before this PR. If you are good with hardcoded colours (for now), I'm fine with that! 👍 |
### What does this PR do? * Adds the ability to upload to AWS through build * Toggled advanced features section ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes containers#487 ### How to test this PR? <!-- Please explain steps to reproduce --> 1. Add your credentials to ~/.aws/credentials 2. Build your image + provide your bucket, aminame, etc. Signed-off-by: Charlie Drage <[email protected]>
feat: add AWS uploading image
What does this PR do?
Screenshot / video of UI
What issues does this PR fix or reference?
Closes #487
How to test this PR?
Signed-off-by: Charlie Drage [email protected]