-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: system tests: parallelize 010 #24549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test/system/010-images.bats
Outdated
while [[ "$output" =~ "$(safename)" ]] && [[ $tries -gt 0 ]]; do | ||
# Prior to #18980, 'podman images' during rmi could fail with 'image not known' | ||
# '0+w' because we sometimes get warnings. | ||
run_podman 0+w images --format "{{.ID}} {{.Names}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait the warning that we ignore here here was fixed #23331 so this can/should be removed
Final cleanup. Has been working fine in containers#23257 for weeks. Not much gain here, but every little bit helps. Signed-off-by: Ed Santiago <[email protected]>
91acf8e
to
1c77ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Final cleanup. Has been working fine in #23257 for weeks.
Not much gain here, but every little bit helps.
Signed-off-by: Ed Santiago [email protected]