Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync fork with iancanderson/ingreedy #11

Merged
merged 17 commits into from
Mar 26, 2024
Merged

Sync fork with iancanderson/ingreedy #11

merged 17 commits into from
Mar 26, 2024

Conversation

liamnichols
Copy link
Member

@liamnichols liamnichols commented Mar 26, 2024

I noticed that our fork was a little behind the original gem (iancanderson/ingreedy) so I figured that it would be worth syncing the changes so that we don't stray too far away from the original library.

The changes in this sync

Change Note
Add the MIT license
Change the dependency constraints on parslet Not a lot to be concerned with in v2 - https://github.com/kschiess/parslet/blob/master/HISTORY.txt
Improve British English support in the dictionary I'll apply this to our dictionary too
Fix a bug with parsing of ninety in the English dictionary We had already patched this in our apps
Update CI We had already updated this, i'm going to add 3.3 checks in a new PR
Bump Version to 0.1.0 We can also bump it to 0.1.1 in #10

andyw8 and others added 17 commits January 28, 2016 16:37
Allow these to be entered in a variety of ways, but for consistency and
simplicity keep using the US spelling when outputting them.

https://en.wikipedia.org/wiki/Litre
https://en.wikipedia.org/wiki/Kilogram
https://en.wikipedia.org/wiki/Gram
…rnational-spellings

Allow British and international spellings
Provide option for preserving amounts
Could you add this (or any other) license? :)
This uses GitHub actions now
@liamnichols liamnichols marked this pull request as ready for review March 26, 2024 07:26
@liamnichols liamnichols self-assigned this Mar 26, 2024
Copy link

@sota-horiuchi sota-horiuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also bump it to 0.1.1 in #10

OK

@liamnichols liamnichols merged commit 778139f into master Mar 26, 2024
5 checks passed
@liamnichols liamnichols deleted the ln/sync-fork branch March 26, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants