Validate Avro schema before encoding

cookpad · Apr 29, 2024 · 3c0bdad · 3c0bdad
1 parent 6cd65da
commit 3c0bdad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/streamy/serializers/avro_serializer.rb b/lib/streamy/serializers/avro_serializer.rb
@@ -20,7 +20,10 @@ def self.clear_messaging_cache
       end
 
       def self.encode(payload, schema_namespace: nil)
-        messaging.encode(payload.deep_stringify_keys, schema_name: payload[:type], namespace: schema_namespace)
+        messaging.encode(payload.deep_stringify_keys,
+                         schema_name: payload[:type],
+                         namespace: schema_namespace,
+                         validate: true)
       end
     end
   end

diff --git a/test/avro_event_test.rb b/test/avro_event_test.rb
@@ -88,7 +88,7 @@ def test_helpful_error_message_on_incorrect_attribute_type
       exception = assert_raises Streamy::PublicationFailedError do
         IncorrectAttributeEvent.publish
       end
-      assert_match("Avro::IO::AvroTypeError", exception.message)
+      assert_match("Avro::SchemaValidator::ValidationError", exception.message)
     end
 
     def test_helpful_error_message_on_event_with_no_schema