Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youku #1431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Youku #1431

wants to merge 2 commits into from

Conversation

NotCJSBirdie
Copy link

I would like to see the source code and contribute

@cookpete
Copy link
Owner

I forgot that branch existed! I just need someone with a Youku client id to test that it works.

@NotCJSBirdie @ImranBugCMG @rocklaam are you able to test the youku branch?

Something like:

<ReactPlayer
  url='https://v.youku.com/v_show/id_XNTg4NjExNzY3Ng==.html'
  config={{ clientId: '12345' }}
/>

@ImranBugCMG
Copy link

ImranBugCMG commented Jul 19, 2022

@cookpete so far findings are that example document is not working for youku in this branch.

In example code after entering youku url in input field, it shows an error using the alert method of browser which reads: [Fail]The params of {vid,target,client_id} are necessary !
Note: clientId was provided.

and in console I was getting following error: TypeError: Cannot read properties of null (reading 'getElementsByTagName')

If I get time I will try to debug this.

@cookpete
Copy link
Owner

Thanks for trying @ImranBugCMG – If you are happy to privately share your client ID with me, I can try and debug it too. I’m at https://twitter.com/cookpete or email pete [at] cookpete [dot] com

@ImranBugCMG
Copy link

Thanks for trying @ImranBugCMG – If you are happy to privately share your client ID with me, I can try and debug it too. I’m at https://twitter.com/cookpete or email pete [at] cookpete [dot] com

I have sent you an email

@AntonOfTheWoods
Copy link

Did any progress get made on this? I will have an ID to test with if you need one, and will have a look myself to try and get it working.

static displayName = 'Youku'
static canPlay = canPlay.youku
callPlayer = callPlayer
playerID = this.props.config.playerId || `${PLAYER_ID_PREFIX}${randomString()}`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name playerID here is incorrect, which leads to an error in referencing this.playerId below. Therefore, the error messages [Fail]The params of {vid,target,client_id} are necessary! and TypeError: Cannot read properties of null (reading 'getElementsByTagName') occur.

By changing it to playerId the issue can be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants