-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youku #1431
base: master
Are you sure you want to change the base?
Youku #1431
Conversation
I forgot that branch existed! I just need someone with a Youku client id to test that it works. @NotCJSBirdie @ImranBugCMG @rocklaam are you able to test the Something like: <ReactPlayer
url='https://v.youku.com/v_show/id_XNTg4NjExNzY3Ng==.html'
config={{ clientId: '12345' }}
/> |
@cookpete so far findings are that example document is not working for youku in this branch. In example code after entering youku url in input field, it shows an error using the alert method of browser which reads: and in console I was getting following error: If I get time I will try to debug this. |
Thanks for trying @ImranBugCMG – If you are happy to privately share your client ID with me, I can try and debug it too. I’m at https://twitter.com/cookpete or email |
I have sent you an email |
Did any progress get made on this? I will have an ID to test with if you need one, and will have a look myself to try and get it working. |
src/players/Youku.js
Outdated
static displayName = 'Youku' | ||
static canPlay = canPlay.youku | ||
callPlayer = callPlayer | ||
playerID = this.props.config.playerId || `${PLAYER_ID_PREFIX}${randomString()}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name playerID
here is incorrect, which leads to an error in referencing this.playerId
below. Therefore, the error messages [Fail]The params of {vid,target,client_id} are necessary!
and TypeError: Cannot read properties of null (reading 'getElementsByTagName')
occur.
By changing it to playerId
the issue can be resolved.
I would like to see the source code and contribute