build(deps-dev): bump mypy from 1.11.2 to 1.12.0 #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [mypy](https://github.com/python/mypy) from 1.11.2 to 1.12.0. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.11.2...v1.12.0) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1816 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 49 49
Lines 5098 5098
=======================================
Hits 4985 4985
Misses 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sisp
reviewed
Oct 14, 2024
| @@ -421,7 +421,7 @@ def get_when(self) -> bool: | |||
|
|
|||
| def render_value( | |||
| self, value: Any, extra_answers: AnyByStrDict | None = None | |||
| ) -> str: | |||
| ) -> Any: | |||
There was a problem hiding this comment.
The previous return type str was strictly wrong; I'm surprised an earlier version of mypy didn't catch it. I decided to widen the type to Any, as typing this method precisely seems quite difficult and doesn't add much value at this point. Also, this method is part of our internal API, so there is no effect on our users.
sisp
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps mypy from 1.11.2 to 1.12.0.
Changelog
Sourced from mypy's changelog.
... (truncated)
Commits
f2a39b1Update version to 1.12.0b4ec37aAdd one more 1.12 changelog item (#17936)cc1c679Better handling of generic functions in partial plugin (#17925)d65a013Add latest 1.12 changes to changelog (#17921)2e38965Fix union callees with functools.partial (#17903)c5d3673Document ReadOnly (PEP 705) (#17905)964a7a5Make ReadOnly TypedDict items covariant (#17904)24bfb34Include CHANGELOG.md in sdists (#17882)21d46eddocumentation for TypeIs (#17821)c692943Improvements to functools.partial of types (#17898)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)